-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add x-out-of-boundaries attribute to popover #1835
Closed
Comments
khanilov
added a commit
to khanilov/reactstrap
that referenced
this issue
May 12, 2020
12 tasks
khanilov
added a commit
to khanilov/reactstrap
that referenced
this issue
May 12, 2020
iamandrewluca
pushed a commit
that referenced
this issue
May 21, 2020
Hi! |
@JunHyeokHa |
@khanilov |
This was referenced Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PopperContent
^8.4.1
es
^16.8.6
^4.3.1
What is happening?
Popper hide modifier has no effect on rendered popover.
What should be happening?
Add
x-out-of-boundaries
attribute fordiv
rendered byReactPopper
whenoutOfBoundaries
field in render prop argument is true.outOfBoundaries
is passed to render prop function byReactPopper
, but not used inPopperContent
component.Proofs:
https://github.com/popperjs/react-popper/blob/v1.3.6/src/Popper.js#L208-L218
https://github.com/reactstrap/reactstrap/blob/master/src/PopperContent.js#L149-L160
Motivation behind
x-out-of-boundaries
: https://github.com/reactstrap/reactstrap/blob/master/src/PopperContent.js#L149-L160The text was updated successfully, but these errors were encountered: