Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for ListGroup and add ListGroupItem, heading, text #185

Closed
eddywashere opened this issue Oct 18, 2016 · 2 comments
Closed

Add docs for ListGroup and add ListGroupItem, heading, text #185

eddywashere opened this issue Oct 18, 2016 · 2 comments
Labels
docs Hacktoberfest help wanted
Milestone
Stable Release

Comments

@eddywashere
Copy link
Member

Following up on the original ListGroup component work.

http://v4-alpha.getbootstrap.com/components/list-group/

ListGroupItem should support

  • active
  • disabled
  • action
  • color

Also, add the following components ListGroupItemHeading ListGroupItemText. Defaulting to the tags used in the docs.
@eddywashere eddywashere added this to the Stable Release milestone Oct 18, 2016
@LiJinyao
Copy link
Contributor

I'll do that!

@LiJinyao LiJinyao mentioned this issue Oct 21, 2016
Merged
@eddywashere
Copy link
Member Author

@LiJinyao released these components in 3.9.0

@LiJinyao LiJinyao mentioned this issue Nov 24, 2016
Merged
eddywashere pushed a commit that referenced this issue Dec 1, 2016
@LiJinyao @eddywashere
feat(ListGroup): prevent onClick when disabled & add docs #185 (#236)
1301b11 
* init ListGroup doc

* Prevent click event when disabled.

* set contextual classes by pass status props directly

I use a color prop to pass contextual classes info to the component,
when you want to set a status, you must type `color=“success”`. It
trivially to do so.
Now you just need pass a `success` bool prop to show the status.

* ListGroup Doc

* add test for disabled item

* change back to color prop

* remove Container

* move disable handler function out
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Hacktoberfest help wanted
Projects
None yet
Milestone
Stable Release
Development

No branches or pull requests
2 participants
@eddywashere @LiJinyao