Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add crossfade to Carousel #2555

Closed
illiteratewriter opened this issue Jun 20, 2022 · 3 comments · Fixed by #2558
Closed

Add crossfade to Carousel #2555

illiteratewriter opened this issue Jun 20, 2022 · 3 comments · Fixed by #2558
Assignees
@nerdjfpb
Labels
good first issue

Comments

@illiteratewriter
Copy link
Member

  • components: Carousel

Carousel component doesn't have crossfade prop. Bootstrap doc for crossfade.
@nerdjfpb
Copy link
Contributor

Hi @illiteratewriter I'm new to codebase, but I'm interested to pick this issue. Can I take this?

@illiteratewriter
Copy link
Member Author

Sure. Go ahead. I think it actually has a prop called fade, but it is not working as expected.

@nerdjfpb nerdjfpb mentioned this issue Jun 23, 2022
Merged
14 tasks
@nerdjfpb
Copy link
Contributor

Hi @illiteratewriter I've write a solution, can you review this? Thanks

illiteratewriter added a commit that referenced this issue Jun 24, 2022
@illiteratewriter
Merge pull request #2558 from nerdjfpb/carousel-fade-fix
7775c96 
fix(#2555): Add crossfade to Carousel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nerdjfpb nerdjfpb

Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#2555): Add crossfade to Carousel nerdjfpb/reactstrap
2 participants
@illiteratewriter @nerdjfpb