Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customize tag for Col #314

Closed
juangl opened this issue Jan 30, 2017 · 5 comments · Fixed by #315 or #317
Closed

Customize tag for Col #314

juangl opened this issue Jan 30, 2017 · 5 comments · Fixed by #315 or #317

Comments

@juangl
Copy link

juangl commented Jan 30, 2017

Could I render a <Col> with an aside, nav or main tag instead a div?
@TheSharpieOne
Copy link
Member

You can use the tag prop, such as <Col tag="aside">

@juangl
Copy link
Author

juangl commented Jan 30, 2017

Is it a recently added prop? I'm using Reactrap 4.0.1 and I get:

Warning: Unknown prop `tag` on <div> tag. Remove this prop from the element. For details, see

@TheSharpieOne
Copy link
Member

Sorry, apparently Col is not like the other components, it has div hard-coded as the element.
@eddywashere was there a reason for this or should it be updated to support the tag prop like the other components?

@eddywashere
Copy link
Member

Missed it when updating components. +1 to add. Also worth checking any other missing tag props.

TheSharpieOne added a commit to TheSharpieOne/reactstrap that referenced this issue Jan 30, 2017
@TheSharpieOne
fix(*): make sure everything can have a Tag
6ca90d8 
fixes reactstrap#314
@TheSharpieOne TheSharpieOne mentioned this issue Jan 30, 2017
Merged
TheSharpieOne added a commit to TheSharpieOne/reactstrap that referenced this issue Jan 30, 2017
@TheSharpieOne
fix(*): make sure everything can have a Tag
ca5075b 
fixes reactstrap#314
eddywashere pushed a commit that referenced this issue Jan 31, 2017
@TheSharpieOne @eddywashere
fix(*): make sure everything can have a Tag (#315)
3373a90 
fixes #314
@eddywashere eddywashere mentioned this issue Jan 31, 2017
Merged
@eddywashere
Copy link
Member

released in 4.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@eddywashere @TheSharpieOne @juangl