Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navbar (.fixed-top) overshadows Modal #342

Closed
alihammad-gist opened this issue Feb 27, 2017 · 2 comments · Fixed by #357
Closed

Navbar (.fixed-top) overshadows Modal #342

alihammad-gist opened this issue Feb 27, 2017 · 2 comments · Fixed by #357

Comments

@alihammad-gist
Copy link

Issue description

Navbar with .fixed-top className overshadows Modal. Modal has the default zIndex set to 1000 while Navbar.fixed-top has zIndex set to 1030. The problem can be fixed by setting Modal zIndex property to greater than 1030.

  • version #4.2.0
  • components: Modal

Steps to reproduce issue

http://codepen.io/alihammad-gist/pen/MpwBeY

  • ...
@TheSharpieOne
Copy link
Member

Looks like bootstrap uses z-index of 1050. This was an oversight on my part

TheSharpieOne added a commit to TheSharpieOne/reactstrap that referenced this issue Feb 27, 2017
@TheSharpieOne
fix(Modal): default zIndex to 1050
5504f60 
Fixes reactstrap#342
@TheSharpieOne TheSharpieOne mentioned this issue Feb 27, 2017
Merged
eddywashere pushed a commit that referenced this issue Mar 14, 2017
@TheSharpieOne @eddywashere
fix(Modal): default zIndex to 1050 (#343)
8d0f4ec 
Fixes #342
@eddywashere eddywashere mentioned this issue Mar 14, 2017
Merged
@TheSharpieOne
Copy link
Member

can you reproduce this using https://stackblitz.com/edit/reactstrap?file=Example.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(release): adding 4.3.0 reactstrap/reactstrap
2 participants
@TheSharpieOne @alihammad-gist