-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.6.1] Reactstrap dist minified builds broken #429
Comments
Thanks for reporting! Sounds like this affects people that point to a cdn hosted version or point to minified file in build tooling. Was this working in the previous release or has this been broken since rollup integration? I'll leave this up for grabs, if you work on it please call it here or slack. Otherwise I'll look at it this evening. Thanks! |
Was working as of 4.5.0 with the addition of Rollup PR #386. Perhaps could be using development version of React/invariant now for dist builds. @eddywashere Yes affects exactly those two cases. Testing external from CDN and when including via tooling into app from |
Thanks! It's likely part of the roll up plugin changes I did. 8b379a4 Should be safe to revert or look at what broke between major versions. |
https://github.com/reactstrap/reactstrap/blob/master/package.json#L5 should not be pointing to the dist, but the lib. |
@TheSharpieOne what about the other values that point to dist as well ... |
Should be fixed in #433 |
#433 will not fix the dist builds being development builds (for things like UMD, as mentioned here). It only fixes when importing from node_modules. |
@vigrofx for es modules, the dist works. Extra components will be removed via tree shaking |
should be good now with 4.6.2. Upgrade notes: make sure all peer deps are installed with |
The minified versions are broken in 4.6.1. Somehow the build does not produce proper UMD output with latest Rollup. See output:
invariant.js:26
The text was updated successfully, but these errors were encountered: