Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aria-label="Close" in Alert and ModalHeader components is hardcoded #524

Closed
rafalp opened this issue Aug 6, 2017 · 0 comments · Fixed by #525
Closed

aria-label="Close" in Alert and ModalHeader components is hardcoded #524

rafalp opened this issue Aug 6, 2017 · 0 comments · Fixed by #525
Labels
PR Welcome up-for-grabs

Comments

@rafalp
Copy link

rafalp commented Aug 6, 2017 •
edited
Loading

Issue description

  • version master
  • components: Alert, ModalHeader

Currently the Alert and ModalHeader components hardcode the aria-label="Close" attribute, which seems inconsistend with rest of components, and makes it impossible to inject localized label from the application:

https://github.com/reactstrap/reactstrap/blob/master/src/Alert.js#L62
https://github.com/reactstrap/reactstrap/blob/master/src/ModalHeader.js#L38
@supergibbs supergibbs mentioned this issue Aug 7, 2017
Merged
TheSharpieOne pushed a commit that referenced this issue Aug 7, 2017
@supergibbs @TheSharpieOne
feat(aria): add closeAriaLabel (#525)
3b4c0e6 
Add closeAriaLabel to Alert and ModalHeader to override default close value

Closes #524
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PR Welcome up-for-grabs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Better internationalization support for aria-labels
2 participants
@TheSharpieOne @rafalp