-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropdown in Navbar #637
Comments
@supergibbs I'd like to take this up. I think I understand the issue, but I'd like to get it clarified before I begin trying to fix this: Is it that Does it mean I need to change this to use I'm new to this project and I could've understood it completely wrong. Please feel free to correct me and guide me in the right direction. |
Yes, the current Dropdown always uses popper but it should only use it when not in a Note, this is different than just modifying |
Alright. I'll start working on it. @TheSharpieOne, could you please add the in-progress tag for this, since I'm working on it? |
@supergibbs I've been looking around the code and seeing how I can fix this. Since Is this the best possible solution or you have other suggestions? |
Probably just best to add a navbar prop to the dropdown and trigger logic off if that. |
Hi @supergibbs ! I haven't found time to do this yet. Please go ahead and do it! |
@TheSharpieOne I did this two different ways: #693 One is a very simple prop on #692 The other is a little more complex, using context to remove Let me know which approach you like better. |
I like the context approach (even though using context is typically not the best.... but we are already using it here) as it may lend to having the |
Issue description
NavDropdown
#5.0.0-alpha.3
#4.0.0-beta
What is happening?
In a navbar, the Dropdown still uses popper to position it
What should be happening?
It should just use Bootstrap's CSS when inside a Navbar
Bootstrap disables popper in a navbar: https://github.com/twbs/bootstrap/blob/v4-dev/js/src/dropdown.js#L146
Example here: https://getbootstrap.com/docs/4.0/components/navbar/ (especially noticeable when navbar is collapsed)
The text was updated successfully, but these errors were encountered: