BS4 beta 2 updates for Table #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supergibbs
changed the title
inverse prop for dark on Table
TheSharpieOne
requested changes
Nov 21, 2017
src/Table.js
Outdated
| hover ? 'table-hover' : false, | ||
| reflow ? 'table-reflow' : false | ||
| ), cssModule); | ||
|
|
||
| const table = <Tag {...attributes} className={classes} />; | ||
|
|
||
| if (responsive) { | ||
| const responsiveClassName = responsive === true ? 'table-responsive' : `table-${responsive}-responsive`; |
There was a problem hiding this comment.
looks like it should be table-responsive-${responsive}.
Also looks like they killed the wrapper needed for responsive (something that was missing in alpha.6 upgrade)
There was a problem hiding this comment.
But the tests pass? :P wow, can't believe I missed that!
src/Table.js
Outdated
| hover: PropTypes.bool, | ||
| reflow: PropTypes.bool, | ||
| responsive: PropTypes.bool, | ||
| responsive: PropTypes.oneOfType([PropTypes.bool, PropTypes.oneOf(['sm', 'md', 'lg', 'xl'])]), |
There was a problem hiding this comment.
I would just allow a string in case someone wants to extend bootstrap to add additional/custom breakpoints
PropTypes.oneOfType([PropTypes.bool, PropTypes.string]),
src/Table.js
Outdated
| @@ -44,16 +46,17 @@ const Table = (props) => { | |||
| size ? 'table-' + size : false, | |||
| bordered ? 'table-bordered' : false, | |||
| striped ? 'table-striped' : false, | |||
| inverse ? 'table-inverse' : false, | |||
| (dark || inverse) ? 'table-dark' : false, | |||
| hover ? 'table-hover' : false, | |||
| reflow ? 'table-reflow' : false | |||
There was a problem hiding this comment.
Just noticing reflow was removed in bootstrap alpha.6, can you kill it in this PR 🙏
|
@TheSharpieOne I think this one is good to go. Let me know if there is anything else. |
TheSharpieOne
approved these changes
Dec 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#575