Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "dropright"/"dropleft" prop to Dropdown component #785

Closed
DhawalRank-zz opened this issue Jan 18, 2018 · 4 comments
Closed

Adding "dropright"/"dropleft" prop to Dropdown component #785

DhawalRank-zz opened this issue Jan 18, 2018 · 4 comments

Comments

@DhawalRank-zz
Copy link

DhawalRank-zz commented Jan 18, 2018

Issue description

  • components: Dropdown
  • reactstrap version: 4.8.0
  • import method 'reactstrap/DropDown';
  • react version 16.2.0
  • bootstrap version 4

What is happening?

Nesting a dropdown into another dropdown

What should be happening?

There should be a prop option "drop" right as provided by bootstrap as a class named "dropright" to open the dropdown menu on the right of the dropdown button

@TheSharpieOne
Copy link
Member

TheSharpieOne commented Jan 18, 2018

The DropdownMenu has a prop right which accepts a boolean to indicate whether or not the menu should open to the right.
See the Alignment section of https://reactstrap.github.io/components/dropdowns/

Nevermind, I see, they added something new: http://getbootstrap.com/docs/4.0/components/dropdowns/#dropright-variation

@flippidippi
Copy link

flippidippi commented Jan 20, 2018

Just ran into this also. Should we create a new issue with subtasks to get reactstrap caught up with the official release?

@TheSharpieOne
Copy link
Member

We can just use individual issues and add them to the same milestone or project to group them together.

@supergibbs supergibbs added this to To Do in v5.0.0-beta via automation Jan 29, 2018
@supergibbs supergibbs removed this from To Do in v5.0.0-beta Jan 31, 2018
@supergibbs supergibbs added this to To Do in v5.0.0 via automation Jan 31, 2018
@supergibbs supergibbs self-assigned this Feb 6, 2018
supergibbs added a commit to supergibbs/reactstrap that referenced this issue Feb 7, 2018
@supergibbs
Copy link
Collaborator

supergibbs commented Feb 7, 2018

Instead of adding more props I deprecated dropup and replaced with direction. You can set direction to "down" (default), "up", "left" or "right". Is still backwards compatible with dropup IF you don't use direction. See #813

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.0.0
  
Done
4 participants