Tooltip inner ref #1090
Merged
Tooltip inner ref #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p-innerRef * 'master' of github.com:reactstrap/reactstrap: fix(tooltip): fixed tooltip not disappearing on mobile (reactstrap#1083)
TheSharpieOne
requested changes
Jun 25, 2018
src/Tooltip.js
Outdated
| @@ -34,6 +34,7 @@ const propTypes = { | |||
| PropTypes.string, | |||
| PropTypes.number | |||
| ]), | |||
| innerRef: PropTypes.object, | |||
There was a problem hiding this comment.
Technically this can still be a string or a function as well as the new createRef object.
Also need to document the prop (at the very least add it to the props on the docs for this component)
There was a problem hiding this comment.
You're right. I've changed the propType definition and added the proper explanation in the docs
…p-innerRef * 'master' of github.com:reactstrap/reactstrap: feat(Modal): add ref to Modal (reactstrap#1087) feat(alert): add ability to disable fade (reactstrap#1078)
src/Tooltip.js
Outdated
| innerRef: PropTypes.object, | ||
| innerRef: PropTypes.oneOfType([ | ||
| PropTypes.func, | ||
| PropTypes.string |
There was a problem hiding this comment.
PropTypes.object as well, I was merely stating that it can be these 2 in addition to the one previously specified.
TheSharpieOne
approved these changes
Jun 25, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a innerRef prop to the
divwrapping theTooltipso it can accesed from the outsideThis PR solves the issue #1089