Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(issue#1257) - ie foreach error on foreach #1262

Merged
merged 1 commit into from Oct 12, 2018
Merged

fix(issue#1257) - ie foreach error on foreach #1262

merged 1 commit into from Oct 12, 2018

Conversation

jeff-nz
Copy link
Contributor

@jeff-nz jeff-nz commented Oct 12, 2018

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jeff-nz
Copy link
Contributor Author

jeff-nz commented Oct 12, 2018 •
edited

Hi @TheSharpieOne

I have update the fix as per your suggestion for fixing the issue:
#1257

Feel free to merge whenever you are ready.

Regards,
Jeff

@jeff-nz jeff-nz changed the title fix(ie foreach) fix(issue#1257) - ie foreach error on foreach Oct 12, 2018
@TheSharpieOne TheSharpieOne merged commit 522d4ac into reactstrap:master Oct 12, 2018
@gergely-nagy gergely-nagy mentioned this pull request Oct 18, 2018
Closed
@charlesvallieres charlesvallieres mentioned this pull request Nov 22, 2018
Merged
12 tasks
TheSharpieOne pushed a commit that referenced this pull request Nov 26, 2018
@charlesvallieres @TheSharpieOne
fix(ie foreach) (#1304)
1630bb3 
We need to support IE11 so I implemented PR #1262 but I was still getting errors on the `els.forEach` line when els is a NodeList (https://developer.mozilla.org/en-US/docs/Web/API/NodeList/forEach)

#1262
HoneyRole added a commit to HoneyRole/reactstrap that referenced this pull request Nov 22, 2022
@HoneyRole
fix(ie foreach) (#1304)
d693b0f 
We need to support IE11 so I implemented PR #1262 but I was still getting errors on the `els.forEach` line when els is a NodeList (https://developer.mozilla.org/en-US/docs/Web/API/NodeList/forEach)

reactstrap/reactstrap#1262
CyberWarrior1224 pushed a commit to CyberWarrior1224/kriasoft-react-starter-kit that referenced this pull request Mar 27, 2023
@charlesvallieres @CyberWarrior1224
fix(ie foreach) (#1304)
2809967 
We need to support IE11 so I implemented PR #1262 but I was still getting errors on the `els.forEach` line when els is a NodeList (https://developer.mozilla.org/en-US/docs/Web/API/NodeList/forEach)

reactstrap/reactstrap#1262
nicolestandifer3 added a commit to nicolestandifer3/reactstrap that referenced this pull request Aug 6, 2023
@nicolestandifer3
fix(ie foreach) (#1304)
1bfd87f 
We need to support IE11 so I implemented PR #1262 but I was still getting errors on the `els.forEach` line when els is a NodeList (https://developer.mozilla.org/en-US/docs/Web/API/NodeList/forEach)

reactstrap/reactstrap#1262
johnfrench3 pushed a commit to johnfrench3/reactstrap-static-config that referenced this pull request Aug 11, 2023
fix(ie foreach) (#1304)
99e5b38 
We need to support IE11 so I implemented PR #1262 but I was still getting errors on the `els.forEach` line when els is a NodeList (https://developer.mozilla.org/en-US/docs/Web/API/NodeList/forEach)

reactstrap/reactstrap#1262
mattstern31 added a commit to mattstern31/react-strap-static-config that referenced this pull request Nov 12, 2023
@mattstern31
fix(ie foreach) (#1304)
adf07bb 
We need to support IE11 so I implemented PR #1262 but I was still getting errors on the `els.forEach` line when els is a NodeList (https://developer.mozilla.org/en-US/docs/Web/API/NodeList/forEach)

reactstrap/reactstrap#1262
ItoStore added a commit to ItoStore/react-strap that referenced this pull request Dec 15, 2023
@ItoStore
fix(ie foreach) (#1304)
54bd172 
We need to support IE11 so I implemented PR #1262 but I was still getting errors on the `els.forEach` line when els is a NodeList (https://developer.mozilla.org/en-US/docs/Web/API/NodeList/forEach)

reactstrap/reactstrap#1262
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSharpieOne TheSharpieOne TheSharpieOne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeff-nz @TheSharpieOne