fix(Dropdown): improve keyboard ux, WAI-ARIA #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSharpieOne
requested changes
Dec 1, 2018
| <DropdownItem disabled>Action</DropdownItem> | ||
| <DropdownItem>Another Action</DropdownItem> | ||
| <DropdownItem>Some Action</DropdownItem> | ||
| <DropdownItem disabled>Action (disabled)</DropdownItem> |
There was a problem hiding this comment.
"[Another] Action" all start with 'a'
Wanted to better demonstrate the "jump to 1st matching char" feature
|
Tnx for the review @TheSharpieOne. I thought maybe this PR was dead in the water b/c it deviates from BS4 behavior. I'll address your feedback as soon as i have time |
|
I think a11y trumps bootstrap alignment (at least a little). Plus most people will not even notice the difference and if they do, I'm sure they will be happy that it is more accessible. |
eckdanny-osi
force-pushed
the
fix-dropdown-keyboard-nav
branch
from
85ee298
to
ad7727a
Compare
Update event handlers * wrap next/prev * handle ctrl+n/ctrl+p * handle home/end * manage focus on aria-expand/collapse * docs(Dropdown): reword action buttons * return Array<Element> (not NodeList) in getMenuItems return an array of els, not NodeList
eckdanny-osi
force-pushed
the
fix-dropdown-keyboard-nav
branch
from
3a03340
to
92cbd3b
Compare
|
@TheSharpieOne addressed change requests, rebased, ready for final check. If you disagree re |
TheSharpieOne
approved these changes
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1287
Adds additional event-handlers and focus management for the
Dropdowncomponent.