Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add and fix linting for test files #146

Merged
merged 2 commits into from Sep 17, 2016

Conversation

alisd23
Copy link
Contributor

@alisd23 alisd23 commented Sep 16, 2016

  • Add tests folder to linter
  • Fix linting errors for tests
  • Add tests specific .eslint.js file to add extra config
  • Fix eslint issue for atom users
  • Fix npm test command by using double quotes instead of single (please
    mac user check this still works on mac)

Relates to #145

- Add tests folder to linter
- Fix linting errors for tests
- Add tests specific .eslint.js file to add extra config
- Fix npm test command by using double quotes instead of single (please
  mac user check this still works on mac)

Relates to reactstrap#145
@alisd23 alisd23 changed the title test: add and fix tests for linting test: add and fix linting for test files Sep 16, 2016
Copy link
Member

@eddywashere eddywashere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Woot!!! Thanks for doing this!

@eddywashere eddywashere merged commit d747987 into reactstrap:master Sep 17, 2016
@alisd23
Copy link
Contributor Author

alisd23 commented Sep 17, 2016

@eddywashere no problem 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants