-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: treeshaking #2708
fix: treeshaking #2708
Conversation
illiteratewriter
commented
Feb 25, 2023
•
edited
Loading
edited
- fix Tree shaking not working in version 9? #2427
- migrate from microbundle to babel
- Bug fix
- New feature
- Chore
- Breaking change
- There is an open issue which this change addresses
- I have read the CONTRIBUTING document.
- My commits follow the Git Commit Guidelines
- My code follows the code style of this project.
- My change requires a change to the documentation.
- I have updated the documentation accordingly.
- My change requires a change to Typescript typings.
- I have updated the typings accordingly.
- I have added tests to cover my changes.
- All new and existing tests passed.
- migrate from microbundle to babel
Hey, can you test this by using something like yarn link or npm link? npm link will test if the release will still work properly. Other than that it looks good and I think we can merge and release tomorrow. |
- type: "module" caused errors while importing in create react app
@davidacevedo tested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
has it been released yet? |
@adarsh-drishya is there any update on this? |
No mate |
This has been released. But there was a bug in this. The issue should be fixed with the next release. |
So is this fixed now? @illiteratewriter |