Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: treeshaking #2708

Merged

Conversation

illiteratewriter
Copy link
Member

@illiteratewriter illiteratewriter commented Feb 25, 2023

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • My change requires a change to Typescript typings.
    • I have updated the typings accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- migrate from microbundle to babel
@davidacevedo
Copy link
Collaborator

davidacevedo commented Mar 2, 2023

Hey, can you test this by using something like yarn link or npm link? npm link will test if the release will still work properly.

Other than that it looks good and I think we can merge and release tomorrow.

- type: "module" caused errors while importing in create react app
@illiteratewriter
Copy link
Member Author

@davidacevedo tested.

Copy link
Collaborator

@davidacevedo davidacevedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@illiteratewriter illiteratewriter merged commit fa46b94 into reactstrap:master Mar 16, 2023
@adarsh-drishya
Copy link

has it been released yet?

@anoop0567
Copy link

@adarsh-drishya is there any update on this?

@adarsh-drishya
Copy link

No mate

@illiteratewriter
Copy link
Member Author

This has been released. But there was a bug in this. The issue should be fixed with the next release.

@adarsh-drishya
Copy link

So is this fixed now? @illiteratewriter

@illiteratewriter
Copy link
Member Author

@adarsh-drishya https://bundlephobia.com/package/reactstrap@9.2.0 should be. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tree shaking not working in version 9?
5 participants