Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(modal): add 'aria-modal="true"' to modal #2756

Merged
merged 1 commit into from
Jun 9, 2023
Merged

feat(modal): add 'aria-modal="true"' to modal #2756

merged 1 commit into from
Jun 9, 2023

Conversation

adinajohnson
Copy link
Contributor

For better screenreader accessibility so content outside modals is not read by screenreaders — see twbs/bootstrap#27780 and the attribute documentation

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • My change requires a change to Typescript typings.
    • I have updated the typings accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@adinajohnson
feat(modal): add 'aria-modal="true"' to modal
2a43591 
For better screenreader accessibility
@davidacevedo davidacevedo merged commit 6af5b3a into reactstrap:master Jun 9, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidacevedo davidacevedo davidacevedo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adinajohnson @davidacevedo