Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React strict mode #109

Closed
char0n opened this issue Dec 8, 2018 · 1 comment
Closed

React strict mode #109

char0n opened this issue Dec 8, 2018 · 1 comment

Comments

@char0n
Copy link

char0n commented Dec 8, 2018

In Reacts strict mode, react-media is triggering following error when <MediaQuery> component is used.

Warning: Unsafe lifecycle methods were found within a strict-mode tree:
    in Provider (at index-bundle.js:131)

componentWillMount: Please update the following components to use componentDidMount instead: MediaQuery

Would it be possible to comply with the strict mode ?

Thank you
@edorivai
Copy link
Collaborator

Hi @char0n,

#96 should fix this, you can expect it to be merged soon.

@edorivai edorivai mentioned this issue Dec 12, 2018
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@char0n @edorivai