Implement two-pass render (closes #81) #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edorivai
commented
Sep 3, 2018
| ? this.props.defaultMatches | ||
| : this.getMatches() | ||
| }; | ||
| this.onChange(); |
There was a problem hiding this comment.
I'm unsure whether we should be calling onChange in the constructor. I added it now because this is in line with the current behavior.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first stab at implementing the two-pass render as described in #81.
It replaces
componentWillMountforcomponentDidMount, which should address SSR related issues outlined in #91. As well as prepares for the deprecation ofcomponentWillMount.It has an optimization for the "basic" case; if
defaultMatchesis not specified, it will not trigger the two-pass render. So you'll only incur the additional two-pass render cost if you actually specifydefaultMatchesfor SSR, in which case the two-pass is actually recommended by the React team.@mjackson I'd really appreciate a review before merging it in. Also, I've decided to build this on top of
@next, just so I don't have to write it twice. If you prefer to have this backported into v1, I can look into that.Cheers!