-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
images when using URL not working #71
Comments
Does this issue occur with DT's version too, or just the default one? I believe it's fixed in his version and PR. |
OK, tested using the latest native ReadAlong-Web-Component ( and also DT's version of the ReadAlong-Web-Component ) This url images work using that . In a nut shell , Once the 2 default URL's below are updated with the latest ReadAlong-Web-Component, this issue will be resolved.
|
Nice, thanks for doing these tests. So I think we just need to fix DT’s default behaviour about where to find the .xml, .smil and audio files (not in assets/) and then we’ll be able to merge his PR and publish a new version. |
@marctessier I believe this issue has been fixed, since we merged the big WebComponent PR a while ago. Is that correct? |
I just re-tested, confirmed all is now working properly. Got this message at the bottom of logs while processing. The WebComponent is also property displayed the image. This can be closed now. |
closing now since resolved. |
Sweet, thanks for retesting! |
Trying to add an image to to a RA using a url , configured in a json config file..
example json file used:
I ran it like this:
readalongs align --config 1.json --text-input 1.Welcome.txt 1.Welcome.mp3 1
NOTE: I did get this good warning message when producing the RA at the end.
WARNING - Please make sure https://www.btb.termiumplus.gc.ca/images/termium-wet.png is accessible to clients using your read-along.
When we look at the my local http server access logs, we can see the the RA tried to hit the server with a GET and got a 404. Technically , we should not be seeing that hit where my browser should have hit the site "www.btb.termiumplus.gc.ca " instead. Also notice how it tried to use the "/assets" folder as well. The warning message was correct in saying "Please make sure XXXX is accessible to clients using your read-along".
10.0.2.2 - - [19/Aug/2021 10:46:29] code 404, message File not found
10.0.2.2 - - [19/Aug/2021 10:46:29] "GET /assets/https://www.btb.termiumplus.gc.ca/images/termium-wet.png HTTP/1.1" 404 -
( Also technically this should be a ReadAlong-Web-Component bug I think)
The text was updated successfully, but these errors were encountered: