Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlapping phrases #274

Closed
mricgar opened this issue Sep 19, 2022 · 12 comments · Fixed by #281
Closed

Overlapping phrases #274

mricgar opened this issue Sep 19, 2022 · 12 comments · Fixed by #281

Comments

@mricgar
Copy link

mricgar commented Sep 19, 2022

Running the latest (2.2.0) on a real device (Huawei P20pro)
Also reproduced in the test app

Please see the attached video

  1. Open book
  2. Activate scroll mode
  3. Scroll down to the end of the chapter
  4. Disable scroll mode
  5. Navigate between pages horizontally
  6. See error
video5854881666807369227.mp4
@838
Copy link

838 commented Sep 20, 2022

We also experience almost the same issue in our app when the app is resumed after it has been in the background for a while.

screenshot

@mickael-menu
Copy link
Member

I can't reproduce the problem, could you share the book you used in your video?

@mricgar
Copy link
Author

mricgar commented Sep 23, 2022

I share a video playing in the test app with one of the available books. I think this will be more useful

video5865966242958937598.mp4

@mickael-menu
Copy link
Member

Unfortunately I can't fix the problem if I can't reproduce it myself. It looks like a rendering bug in the web view.

@mricgar
Copy link
Author

mricgar commented Sep 30, 2022

How can we help you?

@mickael-menu
Copy link
Member

If you could share with me one of the book exhibiting the issue, maybe I can reproduce it this way. Otherwise try debugging the toolkit yourself to find clues.

@mickael-menu
Copy link
Member

Also you could try using git bisect on the toolkit to find which commit introduced the issue, if it's a regression.

@mickael-menu
Copy link
Member

Good news, I wasn't looking for this but it happened on my device. The issue is the computation of the Readium CSS --RS__viewportWidth which uses an incorrect null width. I'll investigate some more.

 --RS__viewportWidth:calc(0px / 2.75);

@mickael-menu
Copy link
Member

Could you check if this fixes it for you? #281

From branch fix/null-viewport-width

@mickael-menu mickael-menu linked a pull request Oct 3, 2022 that will close this issue
@mricgar
Copy link
Author

mricgar commented Oct 3, 2022

Great! yes, in this fixed "fix/null-viewport-width" it no longer happens to me

@mricgar
Copy link
Author

mricgar commented Oct 3, 2022

¿Do you have an approximate date (months) for the next version is out?

@mickael-menu
Copy link
Member

It should be pretty soon now, we're just finalizing the new Settings API for PDF and then we'll do a new release. A matter of weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants