-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xcode 8 build error when archiving product #261
Comments
As suspected, the workaround has a serious downside:
I advise you to keep a copy of Xcode 7 if you need to submit a new binary to iTunes Connect! |
But surely this can't have been overlooked by Apple, so what is the right answer? I.e. what is wrong with our project that we get into this state/problem? |
I submitted a bug report to Apple. |
@olivierkorner Thanks, Olivier? Did you get a bug reference or pointer back? If and when you do, could you please post it here? |
@rkwright Yes but I think access to Apple bug reports are private. Here's the information:
|
Any update on this one? We are facing the same issue |
setting the library's 'Strip Linked Product' to NO may be helpful! |
@Africa802916 That has been tried, see @olivierkorner comment above. If you do that it creates the archive, but Apple then rejects the archive in the store. So far, we have not found a solution and Apple has not responded to our "bug report" |
Yes 'Strip Linked Product' to NO does work but as rkwright mentioned not a permanent solution |
My Apple bug report has been closed:
|
The CPUCacheUtils / assembly code is really not that critical (and can therefore be removed), in fact it normally is disabled via a preprocessor / compiler directive, see: |
Maybe related: Indeed, when I upload an archive to iTunes Connect, I get an email from Apple saying:
Indeed I see an occurence of thread_local in future.cpp. |
in the LCP/LSD implementation, we disabled Future/Promise entirely, and we removed the pthread-related dependencies which were not necessary and were making life more complicated with some compilers (NDK, Pepper) |
Indeed, I was able to successfully archive and upload it to iTunes Connect after disabling thread_local for iOS! |
How did you disable thread_local? (code removal, or compiler option?) |
@danielweck I disabled it for iOS with a compiler option: readium-sdk/ePub3/utilities/future.cpp Line 130 in b362879
I wanted to add this to the pull request but looks like I'm too late :) |
@olivierkorner but in this case, there should be a compile-time error, right? readium-sdk/ePub3/utilities/future.cpp Line 164 in b362879
# error No TLS implementation for this OS/Compiler
|
@danielweck No, because |
oh, Darwin is included in this macro too, of course. |
Related / duplicate? |
@olivierkorner are you also experiencing #267 ? ...this should be a satisfactory solution, right?
readium-sdk/ePub3/utilities/future.cpp Line 130 in b362879
If so, could you please create a Pull Request, so we can close this issue? |
Fixed by: #268 |
This issue is a Bug
Related issue(s) and/or pull request(s)
#257
#260
Expected Behaviour
Xcode should build an archive file that you can upload to AppStore for validation
Observed behaviour
Archive process fails with error:
Steps to reproduce
In Xcode, choose Archive in the Product menu.
Product
Additional information
A workaround is to set Strip Linked Product to NO in the Build Settings, but there might be yet unknown side effects.
The text was updated successfully, but these errors were encountered: