-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Sphinx #107
Comments
We use ablog https://github.com/readthedocs/blog/blob/master/requirements.txt I think we can check if ablog is compatible with the latest version of sphinx or if we need to update our custom templates https://github.com/readthedocs/blog/tree/master/_themes/rtd-blog |
In this case, the issue seems to be in our .postlist p.first {
font-size: 24px;
}
div.section p {
margin: .75rem .5rem;
line-height: 1.6rem;
} |
There are other styling issues before-and-after, like a different margin on the articles, and for some reason different translations. I wonder if @nienn would have some time to have a look at the CSS differences 😇 |
On a first glance over the screenshots it seems that Sphinx 2.4 is moving from the selector For example, this:
Would become this:
If they decided to move from I still don't have my system ready to test multiple Sphinx versions but this is definitely something I could look over the next few days. |
@nienn here we just want our blog to be compatible with sphinx version we are going to use (2.4), so no need to worry about backwards compatibility. |
@stsewd ok, I wasn't sure about that. Great to know! 😃 |
Actually, the easiest fix here might be to set Long term, I'd see us moving this content to Pelican perhaps, and so we'd have templates/styling completely different from what we have here now. I'm +1 on limping along here for now, but any obvious fixes are good to have in the meantime. |
It worked, thanks @agjohnson ! Sending PR |
Our blog doesn't need a lot of new Sphinx features, but upgrading would help us adopt some extensions and possibly have other small benefits. However, I tried upgrading to Sphinx 2.4 and the HTML changed, so our styles broke:
Therefore, this would require a bit of work.
The text was updated successfully, but these errors were encountered: