Sphinx 6 upgrade post #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
reviewed
Dec 5, 2022
Co-authored-by: Eric Holscher <25510+ericholscher@users.noreply.github.com>
ericholscher
reviewed
Jan 3, 2023
Co-authored-by: Eric Holscher <25510+ericholscher@users.noreply.github.com>
… future maintenance
|
These are really great inputs @ericholscher 💯 |
ericholscher
approved these changes
Jan 4, 2023
|
I think we're waiting on merging readthedocs/sphinx_rtd_theme#1397 then shipping this 👍 |
Co-authored-by: Eric Holscher <25510+ericholscher@users.noreply.github.com>
|
sphinx-rtd-theme 1.2.0rc2 has been released 👍 |
benjaoming
commented
Jan 4, 2023
|
Signing off on this one 👍 @ericholscher please free to merge (or I'll do it tomorrow with fresh eyes) |
|
@benjaoming Sounds good. I'll let you ship it since you wrote it! We should also plan to tweet it, etc. |
benjaoming
commented
Jan 5, 2023
benjaoming
commented
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved out of #189
Closes #198