Skip to content

Commit

Permalink
Merge pull request #838 from readthedocs/davidfischer/negative-keywor…
Browse files Browse the repository at this point in the history
…ds-display

Display negative keywords in the targeting details
  • Loading branch information
davidfischer committed Mar 6, 2024
2 parents 02b4de7 + dd7dae6 commit 78f7d14
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion adserver/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -1131,7 +1131,7 @@ def show_to_keywords(self, keywords):
return False

if self.excluded_keywords:
# If any keyworks from the page in the exclude list, don't show this flight
# If any keywords from the page in the exclude list, don't show this flight
if keyword_set.intersection(self.excluded_keywords):
return False

Expand Down
3 changes: 3 additions & 0 deletions adserver/templates/adserver/includes/flight-metadata.html
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,9 @@
{% if flight.targeting_parameters.include_keywords %}
<li>{% blocktrans with value=flight.targeting_parameters.include_keywords|join:", " %}Include keywords: {{ value }}{% endblocktrans %}</li>
{% endif %}
{% if flight.targeting_parameters.exclude_keywords %}
<li>{% blocktrans with value=flight.targeting_parameters.exclude_keywords|join:", " %}Exclude keywords: {{ value }}{% endblocktrans %}</li>
{% endif %}
{% if flight.targeting_parameters.include_publishers %}
<li>{% blocktrans with value=flight.targeting_parameters.include_publishers|join:", " %}Include publishers: {{ value }}{% endblocktrans %}</li>
{% endif %}
Expand Down

0 comments on commit 78f7d14

Please sign in to comment.