Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for more than one project #9

Closed
stsewd opened this issue Jul 26, 2022 · 3 comments
Closed

Support for more than one project #9

stsewd opened this issue Jul 26, 2022 · 3 comments

Comments

@stsewd
Copy link
Member

stsewd commented Jul 26, 2022

This is the case of our own repo https://github.com/readthedocs/readthedocs.org, where we have the docs and dev projects.

Currently, using the action more than once will override the previous comment

https://github.com/readthedocs/readthedocs-preview/blob/1029696f6a69477ff98e50ddb239e649f86ec384/action.yaml#L51

We should make the comment easier to locate, instead of using a plain ---- as separator, we could use a comment as a delimiter of the start/end of the comment. For example:

<!-- rtd-preview {project} start -->
Content
<!-- rtd-preview {project} end -->

That way, the current "separator" would be part of the template itself

---
:books: Documentation preview :books:: {docs-pr-index-url}
@humitos
Copy link
Member

humitos commented Jul 27, 2022

I liked the idea of using an HTML comment for this! 👍🏼

@humitos
Copy link
Member

humitos commented Jul 27, 2022

This done in c705572

@humitos humitos closed this as completed Jul 27, 2022
@humitos
Copy link
Member

humitos commented Jul 27, 2022

I tested it at readthedocs/sphinx-hoverxref#220 and it worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants