Exclude extra header from offline builders

[stsewd]

Related to readthedocs/readthedocs.org#2637

We don't need to insert the extra header for offline docs.

I tested it locally, it works as expected. We are going to still see this footer

But all the links are dummy, and it's because we set the READTHEDOCS env variable, and we use that on the theme to put some dummy data before it gets replaced by the api response https://github.com/rtfd/sphinx_rtd_theme/blob/ddfdd35e6977f21fb1771734732756b0cf1d6bba/sphinx_rtd_theme/versions.html#L1

[humitos]

I'm not sure what this PR removes. "Downloads" header only or its content?

The screenshot shows the "Downloads" header with no links.

Also, it seems that we want to remove the "Versions" header and its content for the HTMLZip version since there is no another version for this format.

[stsewd]

That comes from the theme https://github.com/rtfd/sphinx_rtd_theme/blob/ddfdd35e6977f21fb1771734732756b0cf1d6bba/sphinx_rtd_theme/versions.html#L1

Nothing we can do about that from the extension.

This removes the injected header

https://github.com/rtfd/readthedocs-sphinx-ext/blob/master/readthedocs_ext/_templates/readthedocs-insert.html.tmpl

Which points to some online resources and causes some errors in the js console. See readthedocs/readthedocs.org#2637

[ericholscher]

Seems reasonable 👍

[ericholscher]

Actually looking at the code, I don't fully understand this. Is there not a better test for this, like checking explicitly for htmlzip format? @stsewd

[ericholscher]

Ignore me, I read it wrong :D

[stsewd]

This PR was out of date, it should be using the constant

readthedocs-sphinx-ext/readthedocs_ext/readthedocs.py

Line 31 in 84aa0ab

ONLINE_BUILDERS = [

[ericholscher]

I pushed up the proper variable name, and am testing locally

[ericholscher]

@stsewd in testing now I'm getting Uncaught ReferenceError: READTHEDOCS_DATA is not defined

[ericholscher]

Aaand, that's from the new Sphinx search extension -- it works without that :)