Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of jquery #115

Merged
merged 4 commits into from
Aug 3, 2022
Merged

Remove usage of jquery #115

merged 4 commits into from
Aug 3, 2022

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jul 14, 2022

There are still more code that depends on jquery and underscorejs,
but this is a good start.

  • Use the fetch API instead of jquery's ajax.
  • Use the URL and URLSearchParams objects instead of our custom code
    to parse search parameters.
  • Had to update the tests, because the new version of selenium remove the find_element_by* methods (pytest-selenium installs the latest version by default).
  • Also updated pytest-selenium, which restricts the version of selenium to 4.x.

There are still more code that depends on jquery and underscorejs,
but this is a good start.

- Use the fetch API instead of jquery's ajax.
- Use the URL and URLSearchParams objects instead of our custom code
  to parse search parameters.
@stsewd stsewd marked this pull request as draft July 14, 2022 18:36
@stsewd stsewd requested review from a team, humitos and agjohnson July 14, 2022 20:01
@stsewd stsewd marked this pull request as ready for review July 14, 2022 20:02
Copy link

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great!

@stsewd stsewd merged commit 5880a64 into main Aug 3, 2022
@stsewd stsewd deleted the remove-some-jquery branch August 3, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants