Make it easy to test locally #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like sphinx 3.5 broke the extension :) taking a look |
|
Looks like they updated underscore.js, I'll check the incompatible changes, also see if we can drop that dep. |
Additionally, disabling the CORS check should be done. I'm using https://addons.mozilla.org/en-US/firefox/addon/cors-everywhere/ for that.
Additionally, disabling the CORS check should be done. I'm using https://addons.mozilla.org/en-US/firefox/addon/cors-everywhere/ for that.
ericholscher
approved these changes
Aug 18, 2021
| @@ -697,7 +697,7 @@ window.addEventListener("DOMContentLoaded", () => { | |||
| const project = READTHEDOCS_DATA.project; | |||
| const version = READTHEDOCS_DATA.version; | |||
| const language = READTHEDOCS_DATA.language || "en"; | |||
| const api_host = '/_'; | |||
| const api_host = READTHEDOCS_DATA.proxied_api_host || '/_'; | |||
There was a problem hiding this comment.
I'd love to standardize this a bit more in some kind of JS library, at some point in the future.
nienn
reviewed
Aug 19, 2021
|
|
||
| cd docs | ||
| pip install sphinx-autobuild | ||
| pip install -r requirement.txt |
There was a problem hiding this comment.
Isn't it the name of this file requirements.txt (plural)?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, disabling the CORS check should be done.
I'm using https://addons.mozilla.org/en-US/firefox/addon/cors-everywhere/ for that.