Fix #92: Search as you type delay #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried "breaking" it several times and I couldn't, so +1 for me! Thanks @nienn 🚀 |
nienn
force-pushed
the
nienn/fix-search-delay
branch
from
8bae13f
to
9b83965
Compare
stsewd
approved these changes
Aug 19, 2021
|
Hmm, tests failed, and then I run them again and now are passing... Maybe there is flaky test now, we should increase the wait time on our tests or find another way to avoid that wait. This was failing readthedocs-sphinx-search/tests/test_ui.py Lines 146 to 148 in 526eb58 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92