Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old webhooks gives 502 #3527

Closed
humitos opened this issue Jan 17, 2018 · 1 comment
Closed

Old webhooks gives 502 #3527

humitos opened this issue Jan 17, 2018 · 1 comment
Labels
Bug A bug Needed: more information A reply from issue author is required

Comments

@humitos
Copy link
Member

humitos commented Jan 17, 2018

Running this command,

$ http POST https://readthedocs.org/github repository:='{"url": "", "ssh_url": ""}' ref=""

breaks the site and may produce tons of tasks being ran.

After running that command I get 502 and I tried it locally and I found that the problem is at the Project query since all the repo urls ends with ''

https://github.com/rtfd/readthedocs.org/blob/445683fc0c86b0de56779447a8eedf98024dba32/readthedocs/core/views/hooks.py#L92-L96

Finally, update_imported_docs is triggered by each of the project.

The only line that could save this execution is

https://github.com/rtfd/readthedocs.org/blob/445683fc0c86b0de56779447a8eedf98024dba32/readthedocs/core/views/hooks.py#L120

Related to #3520

@RichardLitt RichardLitt added the Bug A bug label Jan 17, 2018
@stsewd
Copy link
Member

stsewd commented Mar 9, 2018

Should this be fixed on the query or when parsing the request data?

@stsewd stsewd added the Needed: more information A reply from issue author is required label May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug Needed: more information A reply from issue author is required
Projects
None yet
Development

No branches or pull requests

3 participants