Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better message for memory limit errors #3613

Closed
stsewd opened this issue Feb 15, 2018 · 3 comments
Closed

Better message for memory limit errors #3613

stsewd opened this issue Feb 15, 2018 · 3 comments
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code

Comments

@stsewd
Copy link
Member

stsewd commented Feb 15, 2018

Details

In some cases the build fails due to memory limits, but there isn't a clear message of what happened (I think I see some few projects with the correct message, or maybe none?).

See #3031, #3603, #3612, #3580

Expected Result

A message about memory limit is shown.

Actual Result

A plain message "Build failed" is shown.

I'm not sure if we can catch this types of errors on the environment.

@humitos
Copy link
Member

humitos commented Mar 7, 2018

We have some code written to try to catch this at

https://github.com/rtfd/readthedocs.org/blob/78b5781ad071de656451a262d39458c612c45be0/readthedocs/doc_builder/environments.py#L245-L253

but the problem is that even on a memory limit reached sometimes that exit code is not properly returned and some random things happened. Actually, I think that I added that look for killed in the output because of this issue.

Due those random situations is that we don't have a good solution yet.

@stale
Copy link

stale bot commented Jan 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Jan 10, 2019
@stsewd stsewd added the Accepted Accepted issue on our roadmap label Jan 10, 2019
@stale stale bot removed the Status: stale Issue will be considered inactive soon label Jan 10, 2019
@humitos
Copy link
Member

humitos commented Jul 18, 2019

I think we can close this issue for now since there is not much else we can do to catch when a memory limit was reached.

If we have a plan to reach this goal, we should write it down here and re-open the issue.

@humitos humitos closed this as completed Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
None yet
Development

No branches or pull requests

3 participants