Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latexmk breaks builds outside when DOCKER_ENABLED=False #6343

Closed
agjohnson opened this issue Nov 1, 2019 · 7 comments
Closed

Latexmk breaks builds outside when DOCKER_ENABLED=False #6343

agjohnson opened this issue Nov 1, 2019 · 7 comments
Labels
Accepted Accepted issue on our roadmap Bug A bug Good First Issue Good for new contributors Priority: low Low priority

Comments

@agjohnson
Copy link
Contributor

For users setting up a new instance, we do not recommend that the user uses Docker. Therefore, our attempts to run latexmk fail every build.

To reproduce:

  • Set DOCKER_ENABLED=False
  • Don't have latexmk installed on your host system
  • Run a build
  • See the failure in build output

Core team uses Docker exclusively, so this is low priority. New contributors will hit this however. An easy solution would be to check for DOCKER_ENABLED before trying to use latexmk.

@agjohnson agjohnson added Bug A bug Accepted Accepted issue on our roadmap Priority: low Low priority labels Nov 1, 2019
@stsewd stsewd added the Good First Issue Good for new contributors label Nov 4, 2019
@krptic07
Copy link
Contributor

krptic07 commented Nov 6, 2019

Hi, Can i take up this issue ? And can anyone explain me a little bit what is to be done .

@KartikKapil
Copy link
Contributor

@stsewd i would like to take up this issue ,

@stsewd
Copy link
Member

stsewd commented Nov 6, 2019

Sure, feel free to send a pull request

@KartikKapil
Copy link
Contributor

@stsewd could you kindly guide me through it

@rohitjha941
Copy link

rohitjha941 commented Dec 6, 2019

@KartikKapil Can I take this if you are not working on this?
@stsewd

@Blackcipher101
Copy link
Contributor

@agjohnson should we check if Docker_Enabled=False and then call the function to build latexmk

@stsewd
Copy link
Member

stsewd commented Jul 1, 2021

Now we always recommend using docker compose to contribute to rtd, so I'm closing this

@stsewd stsewd closed this as completed Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug A bug Good First Issue Good for new contributors Priority: low Low priority
Projects
None yet
Development

No branches or pull requests

6 participants