Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organization not showing up in repository list #7381

Closed
josh146 opened this issue Aug 12, 2020 · 38 comments · Fixed by #7430 or #8305
Closed

Organization not showing up in repository list #7381

josh146 opened this issue Aug 12, 2020 · 38 comments · Fixed by #7430 or #8305
Labels
Accepted Accepted issue on our roadmap Needed: documentation Documentation is required

Comments

@josh146
Copy link

josh146 commented Aug 12, 2020

Details

  • Read the Docs project URL: n/a
  • Build URL (if applicable): n/a
  • Read the Docs username (if applicable): JoshIzaac

Expected Result

I am having trouble importing repositories from an organization (https://github.com/PennyLaneAI). I am listed as an owner of the organization, and 3rd party access has been provided to the organization:

image

Actual Result

Pressing the sync button on my ReadTheDocs 'Import a Project' page has no effect; the PennyLaneAI organization is not listed.

@stsewd stsewd added the Support Support question label Aug 12, 2020
@stsewd
Copy link
Member

stsewd commented Aug 13, 2020

@josh146 could you share a screenshot of the https://readthedocs.org/dashboard/import page?

@stsewd stsewd added the Needed: more information A reply from issue author is required label Aug 13, 2020
@josh146
Copy link
Author

josh146 commented Aug 14, 2020

@stsewd Sure!
image

@no-response no-response bot removed the Needed: more information A reply from issue author is required label Aug 14, 2020
@josh146
Copy link
Author

josh146 commented Aug 25, 2020

@stsewd just wondering if there is an update on this? Some (non-owner) members of the organization do have access to the PennyLaneAI organization in their readthedocs dashboard, it is only organization Owners that do not seem to

@stsewd
Copy link
Member

stsewd commented Aug 25, 2020

Sorry, haven't had time to debug this.

Some (non-owner) members of the organization do have access to the PennyLaneAI organization in their readthedocs dashboard, it is only organization Owners that do not seem to

That information is useful, thanks!

@humitos
Copy link
Member

humitos commented Sep 1, 2020

@josh146 I haven't jumped too deep into debugging this, but I guess that it could be solved after today's deploy. There are some cases where RemoteOrganization are not being synced properly due to a bug and it's solved in master already and going out today. I'm not 100% sure that this will solve your issue, but worth to try again tomorrow by hitting the two arrows button to re-sync your repositories and organizations. Please, let us know tomorrow.

@JamesRandom
Copy link

I started seeing this problem yesterday. That update does not seem to have fixed it.

@josh146
Copy link
Author

josh146 commented Sep 4, 2020

@humitos indeed, the update seems to have fixed it for me. Thanks!

@stsewd
Copy link
Member

stsewd commented Sep 4, 2020

We pushed another update yesterday, please try the rezync button again.

@JamesRandom
Copy link

No, still not working for me.

@JamesRandom
Copy link

Aha! I refreshed the page after clicking the sync button and now the organization has appeared!
Thank you

@JamesRandom
Copy link

And now it has disappeared again.

@stsewd
Copy link
Member

stsewd commented Sep 4, 2020

@JamesRandom do you have more than one account connected? (github and gitlab?)

@JamesRandom
Copy link

No, just GitHub. I tried disconnecting and reconnecting the GitHub account, but that didn't help.

@JamesRandom
Copy link

The existing docs from that organization can still be built, so cloning is working. Just no list of repos

@JamesRandom
Copy link

I just logged in to readthedocs with a different browser. When I went to the import page, the organization, and all the doc repos were visible. I hit the refresh button and the organization disappeared.

@JamesRandom
Copy link

This is still not working for me.

@JamesRandom
Copy link

If I log out and then go straight to the import URL (and login) then I get a full list of repositories, but the organisation is not shown in the filter list:
Screenshot 2020-09-08 at 10 20 06

If I hit the refresh button then those repos disappear:
Screenshot 2020-09-08 at 10 20 25

@humitos
Copy link
Member

humitos commented Sep 8, 2020

@JamesRandom Hi! Please, for issues with Read the Docs for Business contact our support team.

We plan to do a deploy today with a fix, so this issue should disappear later today. Thanks you all for the updates!

@chrisjsewell
Copy link
Contributor

Hey @humitos, I'm an owner of https://github.com/orgs/marvel-ncc, but its not showing up in the list (I've tried re-syncing but its still not there)

image

@humitos
Copy link
Member

humitos commented Oct 13, 2020

I'm reopening this issue because it seems that @JamesRandom (jamiep) and @chrisjsewell (cjsewell) still have this problem. I will try to debug this today and come back with an answer.

@humitos humitos reopened this Oct 13, 2020
@humitos
Copy link
Member

humitos commented Oct 13, 2020

@chrisjsewell GitHub returns only 4 organizations for your username when hitting https://api.github.com/user/orgs (

orgs = self.paginate('https://api.github.com/user/orgs')
)

(Pdb) [o.get('login') for o in orgs]
['docutils', 'conda-forge', 'aiidateam', 'executablebooks']

So, there may be something on GitHub's side because we are not getting that information. BTW, accessing to https://github.com/orgs/marvel-ncc gives me 404 to me. Is it a private organization?

@JamesRandom
Copy link

It's actually working for me, after a recent update.

@humitos humitos added the Needed: more information A reply from issue author is required label Oct 13, 2020
@chrisjsewell
Copy link
Contributor

oops left of the last r: https://github.com/marvel-nccr

Hmm, thats weird, on https://github.com/chrisjsewell, it definitely shows this organisation (plus also another new one https://github.com/aiidaplugins which I created):

image

and I'm definitely down as an owner on marvel-nccr:

image

any tips 🤷

@humitos
Copy link
Member

humitos commented Oct 13, 2020

@chrisjsewell can you check what's returning the GitHub's API to you with these commands?

export GITHUB_TOKEN=<your-token-here>

curl --silent -H "Accept: application/vnd.github.v3+json" -H "Authorization: token $GITHUB_TOKEN" https://api.github.com/user/orgs | grep login

@chrisjsewell
Copy link
Contributor

Yep it is there:

$ curl --silent -H "Accept: application/vnd.github.v3+json" -H "Authorization: token $GITHUB_TOKEN" https://api.github.com/user/orgs | grep login
    "login": "docutils",
    "login": "conda-forge",
    "login": "aiidateam",
    "login": "marvel-nccr",
    "login": "executablebooks",
    "login": "aiidaplugins",

FYI, I've got the GitHub hook working to push to RTD and trigger PR builds (another owner remade https://readthedocs.org/projects/quantum-mobile/ and added me as admin), but its still not working to push back to GitHub

image

any easy fix?

@humitos humitos removed the Needed: more information A reply from issue author is required label Oct 14, 2020
@humitos
Copy link
Member

humitos commented Oct 14, 2020

I'm really confused here. I will need more time to debug this because I ran out of ideas about where the problem could be. In my previous comment I saw GitHub not returning that organization. So, maybe the access_token that Read the Docs has in the DB does not have permissions to query that organization? (guessing aloud) 🤔

@stale
Copy link

stale bot commented Nov 29, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Nov 29, 2020
@stsewd
Copy link
Member

stsewd commented Dec 10, 2020

Is anyone still having this problem? With github at least (there is a problem with gitlab #7743). We merged some PRs related to that some time ago that may have fixed this.

@stale stale bot removed the Status: stale Issue will be considered inactive soon label Dec 10, 2020
@chrisjsewell
Copy link
Contributor

Well I'm still have the issue I explained above (https://readthedocs.org/projects/quantum-mobile/builds/) but, as mentioned I only see it for this one organisation/repo, so I think it was just an unlucky set of circumstances.
As you mention, perhaps there's a way I can "refresh" the access token

@anupam-git
Copy link

anupam-git commented Feb 23, 2021

Having the same issue. Cannot see more than 4 organizations in readthedocs page and hence cannot import my repository.
Also if I import it manually, an error shows up saying webhook setup failed.

User : https://github.com/anupam-git
Org : https://github.com/pico-wizard/
image

@humitos
Copy link
Member

humitos commented Mar 12, 2021

@anupam-git @chrisjsewell Hi! Can you confirm that the organization owner has approved the OAuth Read the Docs application? Take a look at this documentation page: https://docs.github.com/en/github/setting-up-and-managing-organizations-and-teams/approving-oauth-apps-for-your-organization

@anupam-git
Copy link

anupam-git commented Mar 12, 2021

@humitos 👏🏼

I had to go to Settings -> Applications -> OAuth Apps -> ReadTheDocs Community and Grant access to that specific organization.

After granting access, I can now see the organization on readthedocs.org

Thank you so much for the reply. 😄

@humitos humitos added the Needed: documentation Documentation is required label Mar 15, 2021
@humitos
Copy link
Member

humitos commented Mar 15, 2021

We should add an entry in our FAQ page for this: https://docs.readthedocs.io/en/latest/faq.html

@humitos humitos added Accepted Accepted issue on our roadmap Needed: documentation Documentation is required and removed Needed: documentation Documentation is required labels Mar 15, 2021
@stsewd
Copy link
Member

stsewd commented Mar 15, 2021

@chrisjsewell
Copy link
Contributor

errr, still having this issue and now also in another organisation: aiidalab/aiidalab#167
I just can't work out how to actually get the ReadTheDocs application to show up in the "Third party access" section of the organisation's settings? (obviously I can't grant access if its not there)
We've tried re-syncing but still it does not show up

@anupam-git
Copy link

errr, still having this issue and now also in another organisation: aiidalab/aiidalab#167
I just can't work out how to actually get the ReadTheDocs application to show up in the "Third party access" section of the organisation's settings? (obviously I can't grant access if its not there)
We've tried re-syncing but still it does not show up

I was referring to GitHub Settings here and not ReadTheDocs Settings :

I had to go to Settings -> Applications -> OAuth Apps -> ReadTheDocs Community and Grant access to that specific organization.

@chrisjsewell
Copy link
Contributor

chrisjsewell commented Mar 25, 2021

Ah fixed it cheers 🎉

The confusion for me was that, to grant access for an organisation (and hence a repo in that organisation) you have to go to your personal GitHub settings and not the organisation's settings

@stsewd stsewd removed the Support Support question label Mar 25, 2021
@humitos
Copy link
Member

humitos commented Mar 26, 2021

@astrojuanlu there is some useful feedback from users here that would be good to document in our docs. There are multiple users bitten by this and it usually confuses ourselves as well. I'd appreciate if you can update our docs when you have some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Needed: documentation Documentation is required
Projects
None yet
6 participants