Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design tooltip #1

Closed
humitos opened this issue Jun 4, 2019 · 2 comments · Fixed by #39
Closed

Design tooltip #1

humitos opened this issue Jun 4, 2019 · 2 comments · Fixed by #39
Labels
Design Design or UX/UI related Improvement Minor improvement to code

Comments

@humitos
Copy link
Member

humitos commented Jun 4, 2019

There are some ideas already implemented in MediaWiki and GitHub from where we can base ours:

We are using this jQuery extension to render the tooltip: https://iamceege.github.io/tooltipster/ so, maybe a theme of it can be created or just adding an extra CSS file it's enough.

The first step for this issue is to create a design document explaining what content should be included in the tooltip, considering the possibilities of having different tooltips type (as GitHub does for PR, issues, user cards, etc) and showing mock examples of they would look like.

This document will help us to know if we need to change something in the API backend or the data that we are getting right now is enough.

We probably can have two instances of this design/implementation:

  1. make it work with what we have already to look nice, but not perfect
  2. grow from there expanding the design and modifying the backend

A help guide about how to write this document, could be this one: https://www.freecodecamp.org/news/how-to-write-a-good-software-design-document-66fcf019569c/

@humitos humitos added Improvement Minor improvement to code help wanted labels Jun 4, 2019
@humitos
Copy link
Member Author

humitos commented Aug 17, 2019

I started an initial implementation of this, just to make it "usable". Example at https://sphinx-hoverxref.readthedocs.io/en/latest/

Screenshot_2019-08-17_16-44-39

There are not a lot more we can do regarding the structure of the content since we receive a HTML blob. In case we want to get the title, sections, paragraph, etc we will need to parse it on the client or modify the Read the Docs API endpoint.

@humitos
Copy link
Member Author

humitos commented Aug 18, 2019

Adding rst-content class to the tooltipster makes it render really nice inheriting all the style from Read the Docs theme.

Screenshot_2019-08-18_02-21-43

@humitos humitos added the Design Design or UX/UI related label Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Design or UX/UI related Improvement Minor improvement to code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants