Support for MicroModal #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humitos
force-pushed
the
humitos/micromodal
branch
from
b977090
to
78d76d3
Compare
- use a similar font size for h1 than the rest (175% looked too big) - use inherit color from `rst-content` class - use h1 for modal title - default modal title option when there is no h1 in the content of modal - add option for default modal title - add option for modal prefix title - change max-width on mobile devices - add link to the content of the page in the title
- sphinx_rtd_theme - alabaster - sphinx_material - typlog
This config works for both, tooltip and modal now. So, the "tooltip" prefix is not needed anymore. I added a warning message and also keep support for the old name.
humitos
removed
the
PR: work in progress
|
I'm requesting review of the Core Team, but I don't think it worth to take a deep look at this. Consider just to ignore this PR if you are not too familiarized with the code and developing Sphinx extensions themselves. |
This was referenced Apr 4, 2020
Use a dictionary to configure each role style: ref, confval, mod, class, etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new completely different style: modal dialogues. It uses MicroModal.js as backend to show them
There is a live example where you can see it in action.
The docs were updated to reflect this new type.
I plan to merge this and make a new 0.2 beta release next week. It was tested on
alabaster,sphinx_rtd_theme,typlogandsphinx_material. They render pretty nice!Closes #22
Closes #1
Closes #26
Closes #25
Closes #40