Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajax header: send the header on each call instead with .ajaxSetup #167

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

humitos
Copy link
Member

@humitos humitos commented Jan 11, 2022

Since .ajaxSetup works globally, it was interfering with other .ajaxSetup
being called in other plugins.

Closes #165

@humitos
Copy link
Member Author

humitos commented Jan 11, 2022

Tests are fixed in #168

Copy link

@nienn nienn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't work with this script before, but the change looks good to me!

Since `.ajaxSetup` works globally, it was interfering with other `.ajaxSetup`
being called in other plugins.
@humitos
Copy link
Member Author

humitos commented Jan 12, 2022

Rebased with master to bring the tests fix.

@humitos humitos merged commit 150f844 into master Jan 12, 2022
@humitos humitos deleted the humitos/ajax-header branch January 12, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

X-HoverXRef-Version header doesn't get set consistently on readthedocs.io
2 participants