Conflicting interpretation of READTHEDOCS

[eine]

In sphinx_rtd_theme/layout.html#L208-L210, _static/js/theme.js is included if not READTHEDOCS. At the same time, sphinx_rtd_theme/versions.html#L1-L36 is included if READTHEDOCS. As a result, the following settings in html_context produce a valid "versions box/menu" in the bottom of the sidebar, but it is not expandable due to the missing js script:

html_context = {
    'READTHEDOCS': True,
	'current_version': 'builders',
    'versions': [ ['builders', '../builders'], ['v0.35', '../v0.35'], ['v0.34', '../v0.34'] ],
	'downloads': [ ['PDF', '/builders.pdf'], ['HTML', '/builders.tgz'] ]
}

In order to fix it, each artifact needs to be edited so that <script type="text/javascript" src="/js/theme.js"></script> (or the corresponding path) is added.

I'd suggest using a different envvar/mechanism in order to know whether the project is to be hosted on readthedocs.org, so that the "versions box/menu" is usable no matter what the host is.

[Blendify]

We can simply change this to like if VERSIONING or similar.
This relates to #438

[Blendify]

@ericholscher @agjohnson why does rtd do this? Why not just leave it up to the theme? The CSS file too.

[ericholscher]

Why does RTD do what?

[Blendify]

Host theme CSS and JS files while projects still have there own in the build static dir

…

On Mon, Jan 15, 2018 at 9:39 PM, Eric Holscher ***@***.***> wrote: Why does RTD do what? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#543 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AOeua9ZC4VdX6yQPjzAkG4DupD0rOHw1ks5tLAvOgaJpZM4RfJp9> .

-- Aaron Carlisle Picture taker | Bit cruncher | Pixel pusher | Document writer | Project administrator for the Blender 3D Documentation Project

[agjohnson]

We do this because our extension points to hosted versions of these resources, but locally the files are still required. I think we're just going to remove the default version list from this theme anyways, as it is causing problems with how we want to be using the theme.

I'll chime in with our requirements on another issue.