Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenreader gives vague information for prev, next buttons #954

Closed
jonels-msft opened this issue Jun 24, 2020 · 2 comments · Fixed by #1007
Closed

Screenreader gives vague information for prev, next buttons #954

jonels-msft opened this issue Jun 24, 2020 · 2 comments · Fixed by #1007
Labels
Bug A bug

Comments

@jonels-msft
Copy link
Contributor

Problem

Although the buttons have informational tooltip text, that text is not announced by the screenreader. Instead it says, "link n, alt plus n" and "link p, alt plus p."

Reproducible Project

https://docs.citusdata.com/en/v9.3/develop/migration.html

Error Logs/Results

Here is a video demonstrating the problem: https://www.youtube.com/watch?v=-tylvGPHwF4

Expected Results

In scan mode the screenreader should announce e.g. the previous link as something like, "Previous link choose distribution column press alt + p to access the control."

Environment Info

  • Python Version: 3.7.7
  • Sphinx Version: 1.4.9
  • RTD Theme Version: 0.2.4
@Daltz333
Copy link

Daltz333 commented Jun 27, 2020

I'm not sure a bug report is valid for such an old version.

Sphinx is already on major version 3
and RTD Theme is already on 0.5.0

@stsewd
Copy link
Member

stsewd commented Oct 7, 2020

Looks like the issue is still valid, the problem is that icon is getting interpreted as text

<div class="rst-breadcrumbs-buttons" role="navigation" aria-label="breadcrumb navigation">
{% if next %}
<a href="{{ next.link|e }}" class="btn btn-neutral float-right" title="{{ next.title|striptags|e }}" accesskey="n">{{ _('Next') }} <span class="fa fa-arrow-circle-right"></span></a>
{% endif %}
{% if prev %}
<a href="{{ prev.link|e }}" class="btn btn-neutral float-left" title="{{ prev.title|striptags|e }}" accesskey="p"><span class="fa fa-arrow-circle-left"></span> {{ _('Previous') }}</a>
{% endif %}
</div>

<span class="fa fa-arrow-circle-left"></span>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@stsewd @Daltz333 @jonels-msft and others