Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CI test for unbuilt assets #1175

Merged
merged 9 commits into from Jul 19, 2021
Merged

Add a CI test for unbuilt assets #1175

merged 9 commits into from Jul 19, 2021

Conversation

agjohnson
Copy link
Collaborator

Many of our PRs have out of date assets, making it hard to test the
latest changes. This will at least throw an error on the PR when build
assets aren't updated.

Many of our PRs have out of date assets, making it hard to test the
latest changes. This will at least throw an error on the PR when build
assets aren't updated.
@agjohnson agjohnson requested review from a team and removed request for a team July 14, 2021 23:39
@agjohnson agjohnson modified the milestones: 1.1, 1.0 Jul 14, 2021
@agjohnson
Copy link
Collaborator Author

Looks like assets are not built in master 🤷

@agjohnson
Copy link
Collaborator Author

agjohnson commented Jul 15, 2021

Actually master looks to not like latest sphinx release as well. These are not my monkeys.

So, uh, disregard all those ❌

@Blendify
Copy link
Member

Tests should now pass after I have rebased the patch.

@agjohnson
Copy link
Collaborator Author

Looks like assets weren't rebuilt on master. Is this error in the failed check clear enough for now?

@agjohnson
Copy link
Collaborator Author

Fixed the error:
image

@agjohnson
Copy link
Collaborator Author

Using job dependencies in the config now too, as build job sometimes ended up the last to build, which ends up backing up our builders needlessly. PR failure will now look like this:

image

Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonder if the depending on the node version the generated files will be different...

.circleci/config.yml Outdated Show resolved Hide resolved
@agjohnson
Copy link
Collaborator Author

In theory, the node version could cause assets could be different, but it's probably unlikely. It's not even clear why we hit this on our application assets, but also we were building with releases as ancient as node 8, so it's not too surprising. Something to watch for I'm sure -- we can either use a circleci node image with unspecified version of python, or pin the version of node allowed in package.json, to eliminate node 8 built assets/etc.

@agjohnson agjohnson merged commit 6417def into master Jul 19, 2021
@agjohnson agjohnson deleted the agj/add-build-test branch July 19, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants