New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a CI test for unbuilt assets #1175
Conversation
Many of our PRs have out of date assets, making it hard to test the latest changes. This will at least throw an error on the PR when build assets aren't updated.
Looks like assets are not built in master 🤷 |
Actually master looks to not like latest sphinx release as well. These are not my monkeys. So, uh, disregard all those ❌ |
Tests should now pass after I have rebased the patch. |
Looks like assets weren't rebuilt on master. Is this error in the failed check clear enough for now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonder if the depending on the node version the generated files will be different...
In theory, the node version could cause assets could be different, but it's probably unlikely. It's not even clear why we hit this on our application assets, but also we were building with releases as ancient as node 8, so it's not too surprising. Something to watch for I'm sure -- we can either use a circleci node image with unspecified version of python, or pin the version of node allowed in package.json, to eliminate node 8 built assets/etc. |
Many of our PRs have out of date assets, making it hard to test the
latest changes. This will at least throw an error on the PR when build
assets aren't updated.