Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1196: Add CSS rule to remove double margins inside dl's #1197

Merged
merged 5 commits into from Aug 19, 2022
Merged

Fix #1196: Add CSS rule to remove double margins inside dl's #1197

merged 5 commits into from Aug 19, 2022

Conversation

nienn
Copy link
Contributor

@nienn nienn commented Aug 11, 2021

Fixes #1196

@nienn nienn requested review from Blendify, agjohnson and a team August 11, 2021 14:02
@Blendify
Copy link
Member

Thanks for looking into this, this has been an issue I have been wanting to look into. Let me test this out on my organization's site to test.

Also let's save this for 1.1

@Blendify Blendify added this to the 1.1 milestone Aug 11, 2021
@benjaoming
Copy link
Contributor

benjaoming commented Aug 19, 2022 •
edited

Added to the demo to see that it works ✔️

image

benjaoming
benjaoming approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@benjaoming benjaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great fix!

@benjaoming benjaoming merged commit 17d51de into master Aug 19, 2022
@benjaoming benjaoming deleted the nienn/fix-dl-double-margins branch August 19, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaoming benjaoming benjaoming approved these changes

@Blendify Blendify Awaiting requested review from Blendify

@agjohnson agjohnson Awaiting requested review from agjohnson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

Parameter list in autodoc output has extra padding
3 participants
@nienn @Blendify @benjaoming