Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show version for Sphinx and this template in footer. #1410

Closed
wants to merge 3 commits into from

Conversation

marxin
Copy link

@marxin marxin commented Jan 13, 2023

Let's continue here where we ended in #1269.

@benjaoming edit:
Fixes #1327

@benjaoming
Copy link
Contributor

Great, thanks for following up @marxin 👍

Before making adjustments in the PR, I want to hear from @agjohnson if he's fine with adjusting the text of the footer as well.

Built with Sphinx 6.1.3 using sphinx-rtd-theme 1.2.0rc2 by Read the Docs.

Looks like:

image

Motivation: The version string looks odd next to "a theme", I think it's because it's very specific to mention the theme version but not its name. This is also shorter.

It should be clear from the name "sphinx-rtd-theme" that it's a theme :)

@benjaoming
Copy link
Contributor

@marxin do you mind if I make some modifications in this PR?

While going over #1327, I realized that we are modifying exactly the same text and perhaps we should fix that issue in the same go. It's about merging the 3 separate strings into one big string for translation.

@marxin
Copy link
Author

marxin commented Jan 19, 2023

@marxin do you mind if I make some modifications in this PR?

Go ahead! I'm fine with that.

@marxin
Copy link
Author

marxin commented Mar 23, 2023

@benjaoming: May I please remind you this PR?

@benjaoming
Copy link
Contributor

Looking good! Now as a single translation string:

image

@marxin
Copy link
Author

marxin commented Apr 4, 2023

Can you please merge it now?

@benjaoming
Copy link
Contributor

I'm good with this. @agjohnson for context, this adds version strings that are really really helpful to be able to diagnose issues with Sphinx/theme faster.

@Geeyun-JY3
Copy link

Why this PR is closed?

@marxin
Copy link
Author

marxin commented Nov 21, 2023

I'm sorry, but the pull request is quite stalled and I've lost interest in the meantime.
Feel free to re-open it in a separate PR.

@Geeyun-JY3
Copy link

Fine :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some translation issues
3 participants