Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use css_tag helper to inject CSS files #1519

Merged
merged 3 commits into from Aug 29, 2023
Merged

Use css_tag helper to inject CSS files #1519

merged 3 commits into from Aug 29, 2023

Conversation

humitos
Copy link
Member

@humitos humitos commented Aug 29, 2023 •
edited

Split #1512 to apply only the CSS/JS tag changes that are required to support Sphinx >= 7.2 (see #1512 (review))

If we need any of these changes specifically for Sphinx 7 support, they can be broken away from some of the cleanup changes here

@humitos humitos requested a review from a team as a code owner August 29, 2023 09:05
@humitos humitos merged commit d34b71b into master Aug 29, 2023
8 checks passed
@humitos humitos deleted the humitos/css-js-tag branch August 29, 2023 09:43
@humitos humitos added this to the 2.0 milestone Aug 29, 2023
This was referenced Aug 29, 2023
Closed
Merged
Closed
@agjohnson agjohnson mentioned this pull request Aug 29, 2023
Closed
This was referenced Sep 28, 2023
Merged
Closed
@felixfontein felixfontein mentioned this pull request Nov 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

arbitrary add_css_file attributes are not supported
1 participant
@humitos