Fix #273 line-block: set the left margin to 0px #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is actually removing intended indent and needs a different solution |
Blendify
changed the title
salarmiii
approved these changes
Mar 17, 2017
- top level have no left margin and a bottom margin - nested have a left margin and no bottom margin
|
I co-opted this PR with some additional fixes. I hope that's ok. Essentially my changes treat top level and nested line blocks slightly differently. Top level line blocks have a bottom margin and no left margin while nested line blocks have a left margin but no bottom margin. This also backports a workaround from RTD.org into the RTD theme.
|
davidfischer
added
PR: ready for review
and removed
PR: work in progress
|
Changes look good to me. Needs aproval from someone else first. |
Blendify
added a commit
to readthedocs/readthedocs.org
that referenced
this pull request
Jan 15, 2018
This should be merged after readthedocs/sphinx_rtd_theme#380 and we use a new release of the theme.
|
I submitted a patch: readthedocs/readthedocs.org#3519 to remove this from the main RTD repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes #273