New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #317: Add styling to block quotes #390
base: master
Are you sure you want to change the base?
Conversation
My personal preference would be to not add the styling to line blocks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line block seems like a strange side effect. Perhaps this should instead style on the first child -- ie:
blockquote > div > div.line-block {
// Leave line block styling alone
}
blockquote > div > p {
// Blockquote styling
}
Not sure what all outputs a blockquote
, it might be best to contain the selector more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree that line block style should not change, but only block quotes.
I think the style looks a bit cramped, how about adding a padding of line-height
to the block? You could remove the margin in that case as well.
Before:
After:
Take note of the comment in the code:
Looking at our demo files the only effects it has is on block quotes and line blocks. I can make it only apply to block quotes. AFAIK this currently would cause issues on my website but would like to get some feedback on this.