Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #317: Add styling to block quotes #390

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix #317: Add styling to block quotes #390

wants to merge 4 commits into from

Conversation

Blendify
Copy link
Member

@Blendify Blendify commented Mar 12, 2017

Before:
blockbefore

After:
blockafter

Take note of the comment in the code:

  // For the most part, its safe to assume that sphinx wants you to use a blockquote as an indent. It gets
  // used in many different ways, so don't assume you can apply some fancy style, just leave it be.

Looking at our demo files the only effects it has is on block quotes and line blocks. I can make it only apply to block quotes. AFAIK this currently would cause issues on my website but would like to get some feedback on this.

@agjohnson agjohnson added the PR: work in progress Pull request is not ready for full review label Mar 12, 2017
@Blendify
Copy link
Member Author

My personal preference would be to not add the styling to line blocks

@Blendify Blendify changed the title Para block Add styling to block quotes fix 317 Mar 12, 2017
@Blendify Blendify changed the title Add styling to block quotes fix 317 Add styling to block quotes fix #317 Mar 12, 2017
@Blendify Blendify added the Needed: design decision A core team decision is required label Mar 12, 2017
@Blendify Blendify changed the title Add styling to block quotes fix #317 Fix #317: Add styling to block quotes Mar 15, 2017
Copy link
Collaborator

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line block seems like a strange side effect. Perhaps this should instead style on the first child -- ie:

blockquote > div > div.line-block {
    // Leave line block styling alone
}

blockquote > div > p {
    // Blockquote styling
}

Not sure what all outputs a blockquote, it might be best to contain the selector more.

@agjohnson agjohnson added this to the v0.4.0 milestone Mar 29, 2018
Copy link
Contributor

@jessetan jessetan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that line block style should not change, but only block quotes.

I think the style looks a bit cramped, how about adding a padding of line-height to the block? You could remove the margin in that case as well.

@agjohnson agjohnson modified the milestones: v0.4.0, 0.5 Jun 7, 2018
@agjohnson agjohnson modified the milestones: 0.5, 0.6 May 3, 2020
@stsewd stsewd mentioned this pull request Dec 3, 2020
@agjohnson agjohnson modified the milestones: 1.1, 1.0 Mar 31, 2021
@agjohnson agjohnson added the Improvement Minor improvement to code label Mar 31, 2021
@agjohnson agjohnson modified the milestones: 1.0, 1.1 Mar 31, 2021
@benjaoming benjaoming modified the milestones: 1.1, 2.0 Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required PR: work in progress Pull request is not ready for full review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants