Allow versions popup to scroll #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessetan
requested review from
ericholscher,
davidfischer,
agjohnson and
Blendify
Blendify
approved these changes
Feb 14, 2018
Blendify
requested changes
Feb 15, 2018
|
@Blendify I saw that padding and decided to leave it alone for this PR since it is unrelated. It might even be desired so that there is some space below the last entry in the navbar. |
emilyemorehouse
added a commit
to cuttlesoft/sphinx_rtd_theme
that referenced
this pull request
Mar 6, 2018
* rtfd/master: (252 commits) Docs: restructure (readthedocs#573) Docs: Fix typos (readthedocs#584) add missing quotes (bottom should be a string) (readthedocs#580) Typo: Contibuting => Contributing Allow versions popup to scroll (readthedocs#576) Add document block and rename bodycontent content Add a block around the page content Docs: httpdomain package name uses dash instead of period Update changlog for 0.2.5 (readthedocs#570) Run Grunt (readthedocs#568) Create CODE_OF_CONDUCT.md (readthedocs#562) readthedocs#463 - Add github, gitlab, bitbucket page arguments option (readthedocs#464) Remove from theme.conf Remove from docs Update footer.html (readthedocs#561) Refactor docs: split up & slim down read me Fix readthedocs#305 Move 1400px media-query to 1100px (readthedocs#396) Only output div.articleComments if the block has content (readthedocs#555) Readme cleanup (readthedocs#554) Add GitHub templates (readthedocs#410) ...
davidfischer
reviewed
May 1, 2018
| @@ -2,10 +2,10 @@ | |||
| position: fixed | |||
| bottom: 0 | |||
| left: 0 | |||
| overflow-y: scroll | |||
There was a problem hiding this comment.
This line appears to be causing an issue.
This was referenced Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Blendify can you please verify this? I have no project on RTD with enough versions to check if this fixes #575.
I've successfully tested against your url with chrome devtools though.
Note that I have removed the top border from that section, since it looked bad when the versions popup was fully expanded. It also fixes something I've always found odd. If this is desired, we can put it back in.
Before:
After: