Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The CJK file name is unreadable #3

Closed
taiansu opened this issue Aug 10, 2021 · 2 comments
Closed

The CJK file name is unreadable #3

taiansu opened this issue Aug 10, 2021 · 2 comments

Comments

@taiansu
Copy link

taiansu commented Aug 10, 2021

The official plugin use normalizePath to generate file name (at here), which will romanize the CJK file names and basically make them become noise instead of information.

Here is the screenshot showing the difference of synced file names from the official plugin and the community one.

截圖 2021-08-11 02 23 25

So in the community plugin, it simply sanitize the name using some regular expressions, but not nomalize it.

@lishid
Copy link

lishid commented Aug 12, 2021

Just want to update here that normalizePath is internally used throughout Obsidian so it shouldn't romanicize CJK or anything - it only converts \ to / and normalizes Unicode representation to NFC form. CJK characters should be left as-is.

@tadeoos
Copy link
Member

tadeoos commented Aug 12, 2021

@taiansu thanks a lot for reporting this!
In the end, it wasn't about the normalizePath function — we do some title sanitization before we even send data to Obsidian. As you pointed out — it was definitely lacking :)

It's now fixed. If you delete your Readwise base folder in Obsidian and trigger the sync again, you should be seeing the correct file names.

Let me know if this is not the case!

@tadeoos tadeoos closed this as completed Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants