Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK-145 chore: added timeout #70

Merged
merged 1 commit into from
May 5, 2023
Merged

SDK-145 chore: added timeout #70

merged 1 commit into from
May 5, 2023

Conversation

HarrisonHough
Copy link
Collaborator

@HarrisonHough HarrisonHough commented May 4, 2023 •
edited by jira bot

SDK-145

Dependencies

Avatar Loader: develop

Description

  • adds a timeout to the module installer to prevent importer getting stuck

Changes

Added

  • timeout to the module installer to prevent importer getting stuck

How to Test

  • You can try importing our package and then immediately turning off wifi/internet connection although this may not actually trigger the timeout, but instead request errors

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.
  • QA Testing is updated.

QA Testing

  • Mention any useful test cases for this feature and add to QA Testing documentation.

Details

  • If more details are necessary to support the description with images and videos add them here.

@HarrisonHough HarrisonHough merged commit 69385a5 into develop May 5, 2023
4 checks passed
@HarrisonHough HarrisonHough deleted the feature/module-installer-update branch May 5, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srcnalt srcnalt srcnalt approved these changes

@rYuuk rYuuk Awaiting requested review from rYuuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HarrisonHough @srcnalt