Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-140] Add setup guide window #71

Merged
merged 5 commits into from
May 8, 2023
Merged

[SDK-140] Add setup guide window #71

merged 5 commits into from
May 8, 2023

Conversation

rYuuk
Copy link
Contributor

@rYuuk rYuuk commented May 5, 2023 •
edited
Loading

SDK-140

Dependencies

Avatar Loader: feature/setup-wizard

Changes

Added

  • Setup guide with panels for subdomain, avatar config and analytics
  • Helper class for layouts

Updated

  • Move scripts and code to avatar loader
  • Extracted field for adding subdomain

Removed

  • Analytics window
  • Quick panel window

How to Test

  • Run the setup from the ready player me menu

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.
  • QA Testing is updated.

QA Testing

  • Mention any useful test cases for this feature and add to QA Testing documentation.

Details

  • If more details are necessary to support the description with images and videos add them here.

@rYuuk rYuuk self-assigned this May 5, 2023
HarrisonHough
HarrisonHough approved these changes May 8, 2023
View reviewed changes
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one small suggestions in comments

Editor/UI/Components/SubdomainField.cs Outdated Show resolved Hide resolved
@rYuuk rYuuk merged commit 8176f7c into develop May 8, 2023
@rYuuk rYuuk deleted the feature/setup-wizard branch May 8, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarrisonHough HarrisonHough HarrisonHough approved these changes

@srcnalt srcnalt Awaiting requested review from srcnalt

Assignees

@rYuuk rYuuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rYuuk @HarrisonHough