Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-259] change meshlod to lod #90

Merged
merged 5 commits into from
Jul 21, 2023
Merged

[SDK-259] change meshlod to lod #90

merged 5 commits into from
Jul 21, 2023

Conversation

rk132
Copy link
Contributor

@rk132 rk132 commented Jul 20, 2023 •
edited by jira bot
Loading

SDK-259

Dependencies

Avatar Loader: branch

Description

  • pass lod parameter to the avatar loader query instead of meshlod

Changes

Updated

  • pass lod parameter to the avatar loader query instead of meshlod

How to Test

  • Open up test scene for avatar lod
  • When changing distance, the LOD is also applied to the head.

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

HarrisonHough
HarrisonHough requested changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just 1 small suggestion in the comments to simplify things a little.

Tests/Editor/AvatarLoaderTests.cs Outdated Show resolved Hide resolved
rYuuk
rYuuk reviewed Jul 20, 2023
View reviewed changes
Copy link
Contributor

@rYuuk rYuuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you align the title of PR with our PR formats(you can check the closed PRs). Also for future, regarding branch name, we don't use ticket number in there as it feels redundant.

@rk132 rk132 changed the title Feat/sdk 259 change meshlod to lod [SDK-259] change meshlod to lod Jul 20, 2023
@rk132 rk132 requested a review from HarrisonHough July 20, 2023 13:05
HarrisonHough
HarrisonHough approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Great stuff!

@rk132 rk132 merged commit 4c05580 into develop Jul 21, 2023
@rk132 rk132 deleted the feat/SDK-259-change-meshlod-to-lod branch July 21, 2023 09:24
@rYuuk rYuuk mentioned this pull request Aug 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rYuuk rYuuk rYuuk left review comments

@HarrisonHough HarrisonHough HarrisonHough approved these changes

@srcnalt srcnalt Awaiting requested review from srcnalt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rk132 @rYuuk @HarrisonHough