Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update install description #33

Merged
merged 1 commit into from
Jan 24, 2024
Merged

feat: update install description #33

merged 1 commit into from
Jan 24, 2024

Conversation

rk132
Copy link
Contributor

@rk132 rk132 commented Jan 19, 2024 •
edited by jira bot

SDK-744

Description

  • Update description for installation, that the package is no longer installed automatically

Changes

Updated

  • Updated readme

HarrisonHough
HarrisonHough approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@HarrisonHough HarrisonHough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good.
However a small issue, not really related to this PR but I think the android steps are wrong.
image
There is actually no microphone or camera usage description in Android. I think this might just be a bit of a copy pasta mistake.

@rk132 rk132 merged commit 18a9345 into develop Jan 24, 2024
0 of 2 checks passed
@rk132 rk132 deleted the feature/update-install-description branch January 24, 2024 07:43
@rk132 rk132 mentioned this pull request Jan 24, 2024
Merged
rk132 added a commit that referenced this pull request Jan 24, 2024
@rk132 @HarrisonHough
Release/v2.2.0 (#34)
9cae463 
## What's Changed
* feat: update install description by @rk132 in
#33

## New Contributors
* @rk132 made their first contribution in
#33

---------

Co-authored-by: Harrison Hough <harrisonhough4@gmail.com>
Co-authored-by: Raigo Kõvask <raigo.kovask@wolf3d.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarrisonHough HarrisonHough HarrisonHough approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rk132 @HarrisonHough